User-Agent is python code

[paalbra]

Here the User-Agent is set to a string containing python code:

PyMISP/pymisp/aping.py

Line 1844 in b1c79f9

user_agent = 'PyMISP {__version__} - Python {".".join(str(x) for x in sys.version_info[:2])}'

Reproduction:

import pymisp

misp = pymisp.ExpandedPyMISP("http://localhost:1337", "asdf")
event = pymisp.MISPEvent()
misp.add_event(event)

Listening to localhost produces:

$ nc -l 1337
GET /servers/getPyMISPVersion.json HTTP/1.1
Host: localhost:1337
User-Agent: PyMISP {__version__} - Python {".".join(str(x) for x in sys.version_info[:2])}
Accept-Encoding: gzip, deflate
Accept: application/json
Connection: keep-alive
Authorization: asdf
content-type: application/json

I assume that this is not intended behavior.

[paalbra]

I do believe that it might just be a missing f since this looks like an f-string. I made a PR that fixes this.

[Rafiot]

🤦‍♂️

Thank you very much...