Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document submodule downloading #156

Merged
merged 1 commit into from
Dec 20, 2017
Merged

document submodule downloading #156

merged 1 commit into from
Dec 20, 2017

Conversation

cvandeplas
Copy link
Member

Adds a missing element that might frustrate other people...

@coveralls
Copy link

coveralls commented Dec 20, 2017

Coverage Status

Coverage remained the same at 51.856% when pulling ef6dd28 on cvandeplas:master into 74640af on MISP:master.

@codecov
Copy link

codecov bot commented Dec 20, 2017

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   51.85%   51.85%           
=======================================
  Files          17       17           
  Lines        2451     2451           
=======================================
  Hits         1271     1271           
  Misses       1180     1180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74640af...ef6dd28. Read the comment docs.

@adulau adulau merged commit a573f3b into MISP:master Dec 20, 2017
@adulau
Copy link
Member

adulau commented Dec 20, 2017

It makes sense for the people not using pip3 ;-) Thank you.

@cvandeplas
Copy link
Member Author

cvandeplas commented Dec 20, 2017

Actually, I am using pip3 to install the github's version of PyMISP. But following some issues it seems the submodule is not automatically pulled when doing pip3 install --upgrade -I .
Or am I doing something wrong?

@adulau
Copy link
Member

adulau commented Dec 20, 2017

Good point. In the standard package, it works (as it's bundled) but indeed for local install you still need to do the sub-module update. We need to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants