Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in add_attachment. Allow explicit attachment naming. #178

Merged
merged 4 commits into from Jan 20, 2018
Merged

Change in add_attachment. Allow explicit attachment naming. #178

merged 4 commits into from Jan 20, 2018

Conversation

korrosivesec
Copy link
Contributor

Added filename parameter and appropriate checks.

@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

Merging #178 into master will decrease coverage by 0.05%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
- Coverage   61.05%   60.99%   -0.06%     
==========================================
  Files          17       17              
  Lines        2506     2510       +4     
==========================================
+ Hits         1530     1531       +1     
- Misses        976      979       +3
Impacted Files Coverage Δ
pymisp/api.py 45.31% <33.33%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c763a4...914ac84. Read the comment docs.

@coveralls
Copy link

coveralls commented Jan 19, 2018

Coverage Status

Coverage decreased (-0.06%) to 60.996% when pulling 914ac84 on CenturyLinkCIRT:master into 0c763a4 on MISP:master.

@Rafiot Rafiot self-assigned this Jan 19, 2018
@Rafiot
Copy link
Member

Rafiot commented Jan 20, 2018

👍

@Rafiot Rafiot merged commit 720dbb9 into MISP:master Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants