Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AbstractMISP.from_dict() do not accept positional argument #205

Merged
merged 1 commit into from Mar 27, 2018

Conversation

mokaddem
Copy link
Contributor

@mokaddem mokaddem commented Mar 15, 2018

Doing the following raise an exception:

json = '''{
    "type": "ip-src",
    "value": "8.8.8.8",
    "category": "Network activity",
    "to_ids": false,
    "proposal": false
    }'''
attribute = MISPAttribute()
attribute.from_json(json)

TypeError: from_dict() takes 1 positional argument but 2 were given

@coveralls
Copy link

coveralls commented Mar 15, 2018

Coverage Status

Coverage remained the same at 64.29% when pulling 3faec3c on mokaddem:hotfix_from_dict into fdd9833 on MISP:master.

@codecov
Copy link

codecov bot commented Mar 15, 2018

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   64.28%   64.28%           
=======================================
  Files          23       23           
  Lines        3408     3408           
=======================================
  Hits         2191     2191           
  Misses       1217     1217
Impacted Files Coverage Δ
pymisp/abstract.py 88.96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd9833...3faec3c. Read the comment docs.

@Rafiot
Copy link
Member

Rafiot commented Mar 27, 2018

Good catch!

@Rafiot Rafiot merged commit 4945a88 into MISP:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants