Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyMISP_tutorial.ipynb #383

Merged
merged 1 commit into from Apr 27, 2019
Merged

Update PyMISP_tutorial.ipynb #383

merged 1 commit into from Apr 27, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2019

The function to collect event_id and put it into a list isn't looking into each MISPAttribute.
Just updated the script to look at it and added a description to what it's doing.

The function to collect event_id and put it into a list isn't looking into each MISPAttribute.
Just updated the script to look it.
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #383 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   51.89%   51.89%           
=======================================
  Files          34       34           
  Lines        6403     6403           
=======================================
  Hits         3323     3323           
  Misses       3080     3080

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 582dda0...47729c4. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.898% when pulling 47729c4 on hackunagi:master into 582dda0 on MISP:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.898% when pulling 47729c4 on hackunagi:master into 582dda0 on MISP:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.898% when pulling 47729c4 on hackunagi:master into 582dda0 on MISP:master.

@adulau adulau merged commit 94f8231 into MISP:master Apr 27, 2019
@adulau
Copy link
Member

adulau commented Apr 27, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants