Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [direct_call] Allows the response type to be something else than a JSON (e.g. csv) #395

Merged
merged 1 commit into from May 22, 2019

Conversation

mokaddem
Copy link
Contributor

PyMISP always expects the response to be of JSON type. However, if you specify the returnFormat in MISP to be, for example, csv, PyMISP will throw an error.
If you see a cleaner way to solve that issue, please say so :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 51.719% when pulling 98ce3f8 on lenientResponseType into 121d885 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 51.719% when pulling 98ce3f8 on lenientResponseType into 121d885 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 51.719% when pulling 98ce3f8 on lenientResponseType into 121d885 on master.

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #395 into master will decrease coverage by 0.03%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   51.75%   51.71%   -0.04%     
==========================================
  Files          35       35              
  Lines        6454     6458       +4     
==========================================
  Hits         3340     3340              
- Misses       3114     3118       +4
Impacted Files Coverage Δ
pymisp/api.py 42.02% <20%> (-0.06%) ⬇️
pymisp/aping.py 10.83% <33.33%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 121d885...98ce3f8. Read the comment docs.

@Rafiot
Copy link
Member

Rafiot commented May 22, 2019

Sounds good to me.

@Rafiot Rafiot merged commit 6620710 into master May 22, 2019
@Rafiot Rafiot deleted the lenientResponseType branch July 7, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants