Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: Initial work on deprecation #417

Closed
wants to merge 1 commit into from
Closed

chg: Initial work on deprecation #417

wants to merge 1 commit into from

Conversation

Rafiot
Copy link
Member

@Rafiot Rafiot commented Jul 12, 2019

Very much not finished.

@coveralls
Copy link

coveralls commented Jul 12, 2019

Coverage Status

Coverage decreased (-3.9%) to 47.666% when pulling c9d58da on deprecate into 9d73a1e on master.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #417 into master will decrease coverage by 0.04%.
The diff coverage is 18.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   51.61%   51.57%   -0.05%     
==========================================
  Files          35       35              
  Lines        6481     5507     -974     
==========================================
- Hits         3345     2840     -505     
+ Misses       3136     2667     -469
Impacted Files Coverage Δ
tests/testlive_comprehensive.py 0% <0%> (ø) ⬆️
pymisp/api.py 84.61% <100%> (+42.62%) ⬆️
pymisp/aping.py 14.6% <17.26%> (+3.76%) ⬆️
pymisp/abstract.py 82.51% <42.85%> (ø) ⬆️
pymisp/mispevent.py 70.81% <50.84%> (-2.27%) ⬇️
pymisp/__init__.py 81.08% <83.33%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1188b8c...7b4e229. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #417 into master will decrease coverage by 3.42%.
The diff coverage is 13.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   51.61%   48.18%   -3.43%     
==========================================
  Files          35       35              
  Lines        6481     5966     -515     
==========================================
- Hits         3345     2875     -470     
+ Misses       3136     3091      -45
Impacted Files Coverage Δ
tests/testlive_comprehensive.py 0% <0%> (ø) ⬆️
pymisp/api.py 84.21% <100%> (+42.22%) ⬆️
pymisp/aping.py 13.35% <14.42%> (+2.51%) ⬆️
pymisp/abstract.py 82.51% <33.33%> (ø) ⬆️
pymisp/mispevent.py 69.89% <47.61%> (-3.18%) ⬇️
pymisp/__init__.py 81.08% <83.33%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d73a1e...c9d58da. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants