Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: Return empty list instead of None #434

Merged
merged 1 commit into from Aug 8, 2019
Merged

Conversation

zaphodef
Copy link
Contributor

@zaphodef zaphodef commented Aug 8, 2019

In all cases but one, the 3rd returned object is a (potentially empty) list.

In all cases but one, the 3rd returned object is a (potentially empty) list.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.286% when pulling a2aa564 on zaphodef:patch-1 into 783b848 on MISP:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.286% when pulling a2aa564 on zaphodef:patch-1 into 783b848 on MISP:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.286% when pulling a2aa564 on zaphodef:patch-1 into 783b848 on MISP:master.

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   38.28%   38.28%           
=======================================
  Files          35       35           
  Lines        6138     6138           
=======================================
  Hits         2350     2350           
  Misses       3788     3788
Impacted Files Coverage Δ
pymisp/tools/create_misp_object.py 21.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783b848...a2aa564. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #434 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #434   +/-   ##
=======================================
  Coverage   38.28%   38.28%           
=======================================
  Files          35       35           
  Lines        6138     6138           
=======================================
  Hits         2350     2350           
  Misses       3788     3788
Impacted Files Coverage Δ
pymisp/tools/create_misp_object.py 21.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783b848...a2aa564. Read the comment docs.

@Rafiot
Copy link
Member

Rafiot commented Aug 8, 2019

Good catch!

@Rafiot Rafiot merged commit b68c3fc into MISP:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants