Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable to_ids based on false positive sightings reporting #461

Merged
merged 4 commits into from
Sep 27, 2019
Merged

Disable to_ids based on false positive sightings reporting #461

merged 4 commits into from
Sep 27, 2019

Conversation

cudeso
Copy link
Contributor

@cudeso cudeso commented Sep 24, 2019

No description provided.

@coveralls
Copy link

coveralls commented Sep 24, 2019

Coverage Status

Coverage remained the same at 38.229% when pulling 5b7eeaa on cudeso:master into 1e0016c on MISP:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 39.014% when pulling c8e9aa4 on cudeso:master into 1e0016c on MISP:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 39.014% when pulling c8e9aa4 on cudeso:master into 1e0016c on MISP:master.

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #461 into master will increase coverage by 10.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #461       +/-   ##
===========================================
+ Coverage   36.02%   46.39%   +10.37%     
===========================================
  Files          35       29        -6     
  Lines        6668     2703     -3965     
===========================================
- Hits         2402     1254     -1148     
+ Misses       4266     1449     -2817
Impacted Files Coverage Δ
tests/test_reportlab.py 0% <0%> (-70.22%) ⬇️
pymisp/tools/sshauthkeyobject.py 0% <0%> (-38.1%) ⬇️
pymisp/tools/load_warninglists.py 0% <0%> (-33.34%) ⬇️
pymisp/tools/emailobject.py 0% <0%> (-21.57%) ⬇️
pymisp/tools/__init__.py 80.95% <0%> (-19.05%) ⬇️
pymisp/__init__.py 72.97% <0%> (-10.82%) ⬇️
pymisp/api.py 84.21% <0%> (-5.27%) ⬇️
pymisp/abstract.py 83.6% <0%> (-3.28%) ⬇️
pymisp/mispevent.py 65.45% <0%> (-2.51%) ⬇️
pymisp/tools/vtreportobject.py 30.43% <0%> (-2.18%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0016c...5b7eeaa. Read the comment docs.

@adulau adulau merged commit c23375c into MISP:master Sep 27, 2019
@adulau
Copy link
Member

adulau commented Sep 27, 2019

Thank you very much for those very good examples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants