Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw exception for invalid uuid #56

Merged
merged 1 commit into from
Mar 8, 2017
Merged

Conversation

rmarsollier
Copy link
Contributor

Throw exception instead if an invalid uuid is given to tag() and untag().

I hope i did it the right way.

@coveralls
Copy link

coveralls commented Mar 8, 2017

Coverage Status

Coverage decreased (-0.1%) to 46.101% when pulling 9c36afb on rmarsollier:master into a2c05b9 on MISP:master.

@codecov-io
Copy link

codecov-io commented Mar 8, 2017

Codecov Report

Merging #56 into master will decrease coverage by -0.12%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #56      +/-   ##
=========================================
- Coverage   46.21%   46.1%   -0.12%     
=========================================
  Files           7       7              
  Lines        1612    1616       +4     
=========================================
  Hits          745     745              
- Misses        867     871       +4
Impacted Files Coverage Δ
pymisp/api.py 41.48% <0%> (-0.18%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2c05b9...9c36afb. Read the comment docs.

@Rafiot
Copy link
Member

Rafiot commented Mar 8, 2017

Yep, that works!

@Rafiot Rafiot merged commit c2ef188 into MISP:master Mar 8, 2017
TheDr1ver pushed a commit to TheDr1ver/PyMISP that referenced this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants