Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [abstract] Forces file to be read with utf8 encoding #565

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

mokaddem
Copy link
Contributor

Make PyMISP opens files in utf-8 and not the system default

@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.024% when pulling f965e57 on fix-force-utf8-on-read into c77603e on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.024% when pulling f965e57 on fix-force-utf8-on-read into c77603e on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.024% when pulling f965e57 on fix-force-utf8-on-read into c77603e on master.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #565 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   38.07%   38.07%           
=======================================
  Files          35       35           
  Lines        7068     7068           
=======================================
  Hits         2691     2691           
  Misses       4377     4377           
Impacted Files Coverage Δ
pymisp/abstract.py 78.40% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77603e...f965e57. Read the comment docs.

@Rafiot Rafiot merged commit 1be38cf into master Apr 24, 2020
@Rafiot Rafiot deleted the fix-force-utf8-on-read branch July 7, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants