-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Timeout for connection/request, fixes #584 #585
Conversation
@Rafiot help, I don't understand what I should do to make Travis happy :-/ |
pymisp/api.py
Outdated
@@ -104,6 +105,7 @@ def __init__(self, url: str, key: str, ssl: bool=True, debug: bool=False, proxie | |||
self.cert: Optional[Tuple[str, tuple]] = cert | |||
self.auth: Optional[AuthBase] = auth | |||
self.tool: str = tool | |||
self.timeout: float = timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be
self.timeout: Optional[float, Tuple[float, float]] = timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And then travis will be happy :)
Thank you! |
This fixes feature request #528
In my own tests all went well, let's see what the automated tests say.