Previously file object was reporting the libmagic description of a file #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of the mimetype. According to [MISP DataModels](https://www.misp-project.org/datamodels/#types) ``` mime-type: A media type (also MIME type and content type) is a two-part identifier for file formats and format contents transmitted on the Internet ``` more precisely defined in [RFC2045](https://tools.ietf.org/html/rfc2045) and others. The description returned by libmagic is more useful than the generic mime-type, but I did not find a place to put the description in the current data model.
kak-bo-che
force-pushed
the
bugfix/correct_mimetype_on_fileobject
branch
from
3e3212d
to
17ebfe8
Compare
1 similar comment
|
Woops, right, good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the mimetype. According to MISP DataModels
more precisely defined in RFC2045 and others.
The description returned by libmagic is more useful than the generic mime-type,
but I did not find a place to put the description in the current data model.