Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop encoding= in Python 3.9 #646

Merged
merged 1 commit into from Oct 27, 2020
Merged

Drop encoding= in Python 3.9 #646

merged 1 commit into from Oct 27, 2020

Conversation

pudo
Copy link
Contributor

@pudo pudo commented Oct 27, 2020

json.load() doesn't have encoding= in Python 3.9. Proposed fix.

@Rafiot
Copy link
Member

Rafiot commented Oct 27, 2020

Yep, looks good, I don't see a reason to keep the encoding set for any python version, as the file is already opened with the encoding set.

We will see if it causes problems with specific setups.

@Rafiot Rafiot merged commit 80764c8 into MISP:main Oct 27, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 36.944% when pulling 5016858 on pudo:python3.9 into ad483b6 on MISP:main.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 36.944% when pulling 5016858 on pudo:python3.9 into ad483b6 on MISP:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants