Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API #651

Merged
merged 3 commits into from Nov 9, 2020
Merged

New API #651

merged 3 commits into from Nov 9, 2020

Conversation

JakubOnderka
Copy link
Contributor

@JakubOnderka JakubOnderka commented Nov 2, 2020

  • New methods PyMIP.event_exists, PyMIP.attribuet_exists and PyMIP.object_exists
  • Add ability to fetch just metadata when adding or editing event

@JakubOnderka JakubOnderka changed the title New api New API Nov 2, 2020
pymisp/api.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Nov 3, 2020

Coverage Status

Coverage decreased (-0.2%) to 36.657% when pulling 6c1f476 on JakubOnderka:new-api into 7e84c36 on MISP:main.

@Rafiot
Copy link
Member

Rafiot commented Nov 3, 2020

Looks good, let me know when I should merge it.

@JakubOnderka
Copy link
Contributor Author

Looks good, let me know when I should merge it.

I just add also checking for attribute and object existence, but first I need to test and merge MISP/MISP#6541.

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #651 (6c1f476) into main (7e84c36) will decrease coverage by 0.21%.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   36.90%   36.69%   -0.22%     
==========================================
  Files          39       39              
  Lines        7765     7825      +60     
==========================================
+ Hits         2866     2871       +5     
- Misses       4899     4954      +55     
Impacted Files Coverage Δ
tests/testlive_comprehensive.py 0.00% <0.00%> (ø)
pymisp/api.py 12.52% <30.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e84c36...6c1f476. Read the comment docs.

@JakubOnderka JakubOnderka marked this pull request as ready for review November 9, 2020 09:48
@JakubOnderka
Copy link
Contributor Author

Ready to merge.

@Rafiot
Copy link
Member

Rafiot commented Nov 9, 2020

Excellent, thank you!

@Rafiot Rafiot merged commit b646f0c into MISP:main Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants