Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to allow PyMISP.add_object to not add duplicates. #683

Closed
wants to merge 2 commits into from

Conversation

Rafiot
Copy link
Member

@Rafiot Rafiot commented Jan 18, 2021

It requires changes on MISP side, do not merge until the tests are passing.

@coveralls
Copy link

coveralls commented Jan 18, 2021

Coverage Status

Coverage decreased (-0.03%) to 39.346% when pulling f806a88 on obj_break_on_duplicates into de6125a on main.

@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #683 (f806a88) into main (de6125a) will decrease coverage by 0.02%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   39.39%   39.36%   -0.03%     
==========================================
  Files          40       40              
  Lines        8204     8210       +6     
==========================================
  Hits         3232     3232              
- Misses       4972     4978       +6     
Impacted Files Coverage Δ
tests/testlive_comprehensive.py 0.00% <0.00%> (ø)
pymisp/api.py 12.42% <33.33%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6125a...f806a88. Read the comment docs.

@Rafiot Rafiot added the S: needs change in MISP Status: needs change in MISP. For this issue to be fixed, a change in MISP is required label Jan 18, 2021
@Rafiot
Copy link
Member Author

Rafiot commented Jan 26, 2021

Merged: c3d6c3c

@Rafiot Rafiot closed this Jan 26, 2021
@Rafiot Rafiot deleted the obj_break_on_duplicates branch January 26, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: needs change in MISP Status: needs change in MISP. For this issue to be fixed, a change in MISP is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants