Merge pull request #49 from eidurorng/fix-external-analysis-classific…

…ation Quick fix for everything getting classified as external analysis
MISP · Jan 26, 2021 · 5eabf6f · 5eabf6f
2 parents 3818ac9 + 5ccb365
commit 5eabf6f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/mail2misp/mail2misp.py b/mail2misp/mail2misp.py
@@ -284,7 +284,7 @@ def process_body_iocs(self, email_object=None):
                                                           to_ids=False, enforceWarninglist=False)
                 if email_object:
                     email_object.add_reference(attribute.uuid, 'contains')
-            elif domainname in self.config.externallist or self.urlsonly is False:  # External analysis
+            elif domainname in self.config.externallist and self.urlsonly is False:  # External analysis
                 attribute = self.misp_event.add_attribute('link', entry, category='External analysis',
                                                           to_ids=False, enforceWarninglist=False)
                 if email_object: