Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreatMiner Expansion module #114

Merged
merged 2 commits into from Mar 8, 2017
Merged

ThreatMiner Expansion module #114

merged 2 commits into from Mar 8, 2017

Conversation

kx499-zz
Copy link
Contributor

@kx499-zz kx499-zz commented Mar 8, 2017

Works off of IP, domains, and hashes and returns information obtained from threatminer.org using their API.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 38.47% when pulling aa3a11c on kx499:master into 44867b2 on MISP:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 38.47% when pulling aa3a11c on kx499:master into 44867b2 on MISP:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 38.47% when pulling aa3a11c on kx499:master into 44867b2 on MISP:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 38.47% when pulling aa3a11c on kx499:master into 44867b2 on MISP:master.

@codecov-io
Copy link

Codecov Report

Merging #114 into master will decrease coverage by -1.5%.
The diff coverage is 11.34%.

@@            Coverage Diff            @@
##           master     #114     +/-   ##
=========================================
- Coverage   39.96%   38.47%   -1.5%     
=========================================
  Files          40       41      +1     
  Lines        2552     2693    +141     
=========================================
+ Hits         1020     1036     +16     
- Misses       1532     1657    +125
Impacted Files Coverage Δ
misp_modules/modules/expansion/init.py 100% <ø> (ø)
misp_modules/modules/expansion/threatminer.py 11.34% <11.34%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44867b2...aa3a11c. Read the comment docs.

@adulau
Copy link
Member

adulau commented Mar 8, 2017

Looks good, I will merge it. Thank you very much.

Maybe you want to update the author meta-information in the module:

moduleinfo = {'version': '2', 'author': 'Hannah Ward',
+              'description': 'Get information from virustotal',
+              'module-type': ['expansion']}

@adulau adulau merged commit 166d871 into MISP:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants