-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple import module to import MISP JSON format #56
Conversation
Current coverage is 40.47% (diff: 44.00%)@@ master #56 diff @@
==========================================
Files 35 36 +1
Lines 2246 2295 +49
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 908 929 +21
- Misses 1338 1366 +28
Partials 0 0
|
Thank you for the contribution. Just wondering, what's the objective compared to the default MISP JSON import? Your module is more populating a new event (new UUID) and adding attributes from another MISP event. The MISP JSON import (in the core) is more to import completely an existing event and to avoid duplicate. Is this the intended use case? |
The intended use case is to merge attributes from existing events together in a new event. Effectively creating copies of the attributes. |
Perfect. Could you just update the description to specify this use case? Then I'll merge it. Thank you very much, |
@RichieB2B When you have time, could you just update the description? Thanks a lot. |
05b8206
to
3a4c540
Compare
Something like 3a4c540 ? |
Looks very good. Thank you. |
Adding attachments ("data" content) doesn't work, but I blame MISP.