Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple import module to import MISP JSON format #56

Merged
merged 2 commits into from
Jan 11, 2017

Conversation

RichieB2B
Copy link
Contributor

Adding attachments ("data" content) doesn't work, but I blame MISP.

@coveralls
Copy link

coveralls commented Sep 28, 2016

Coverage Status

Coverage decreased (-0.08%) to 44.903% when pulling ad0a995 on RichieB2B:ncsc-nl/mispjson into 3b2ccd8 on MISP:master.

@codecov-io
Copy link

codecov-io commented Sep 28, 2016

Current coverage is 40.47% (diff: 44.00%)

Merging #56 into master will increase coverage by 0.05%

@@             master        #56   diff @@
==========================================
  Files            35         36     +1   
  Lines          2246       2295    +49   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            908        929    +21   
- Misses         1338       1366    +28   
  Partials          0          0          

Powered by Codecov. Last update bf5ed3d...3a4c540

@adulau
Copy link
Member

adulau commented Sep 30, 2016

Thank you for the contribution. Just wondering, what's the objective compared to the default MISP JSON import? Your module is more populating a new event (new UUID) and adding attributes from another MISP event. The MISP JSON import (in the core) is more to import completely an existing event and to avoid duplicate. Is this the intended use case?

@RichieB2B
Copy link
Contributor Author

The intended use case is to merge attributes from existing events together in a new event. Effectively creating copies of the attributes.

@adulau
Copy link
Member

adulau commented Sep 30, 2016

Perfect. Could you just update the description to specify this use case? Then I'll merge it. Thank you very much,

@adulau
Copy link
Member

adulau commented Jan 11, 2017

@RichieB2B When you have time, could you just update the description? Thanks a lot.

@RichieB2B
Copy link
Contributor Author

Something like 3a4c540 ?

@coveralls
Copy link

coveralls commented Jan 11, 2017

Coverage Status

Coverage increased (+0.05%) to 40.479% when pulling 3a4c540 on RichieB2B:ncsc-nl/mispjson into bf5ed3d on MISP:master.

@adulau
Copy link
Member

adulau commented Jan 11, 2017

Looks very good. Thank you.

@adulau adulau merged commit 8bdb0fc into MISP:master Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants