Add internal reviewer comments for credential application review #1219 #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas-Mc
force-pushed
the
reviewer_comments
branch
from
71ea6d0
to
a19f32c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an internal reviewer comment field which can be used for storing intermediate thoughts from the reviewer while reviewing a credential application. These comments are persisted throughout each stage of the process where the reviewer can either add more comments or overwrite the current ones. External comments (to the applicant) are no longer persistent and are now only used while rejecting an application. Both internal and external comments can be seem by internal users when viewing previous applications and neither are shown to external users.
Thoughts need to be taken as to whether or not this is the best way to go about comments. Should they be stored separately for each stage? Can we edit them later?
Fixes #1219.