-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django Q2 for task management and scheduling #2207
Conversation
This all looks good and django-q2 sounds like a good way to go; thanks for find it.
Just to be clear: you make it sound like we're not running any periodic background tasks at the moment. We do run periodic tasks using cron. We do not use django-cron to do so. I'm happy to merge this so you can experiment, but please don't change the existing cron jobs until I have a chance to look at them in detail. |
Thanks!
Yep, I'm not saying that we don't run cron tasks. e.g. we're purging old accounts here: physionet-build/deploy/production/etc/cron.d/physionet Lines 11 to 15 in 83c80c5
My point was just that we have django-cron tasks defined in https://github.com/MIT-LCP/physionet-build/blob/dev/physionet-django/physionet/cron.py that (as far as I can see) are not being run: physionet-build/physionet-django/physionet/cron.py Lines 14 to 73 in 83c80c5
|
Why switch to Django Q2
We have a need to be able to:
Right now, we have:
Django Q2 is well documented and under active development. It is compatible with Django 5 (which I hope we can move to soon-ish).
What's in this pull request
This pull request:
After the dependency is added, I would like to: