Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix predicate testing if git is needed #4

Closed
wants to merge 1 commit into from

Conversation

nocnokneo
Copy link

The uses the same predicate in the current MITK/SuperBuild.cmake

@saschazelzer
Copy link
Contributor

Thanks for the pull request. You are using the same expression as in the MITK project, however some CMake variable do not actually make sense in this context.

Could you please describe the problems you run into in the first place?

@nocnokneo
Copy link
Author

Sorry for the slow response. I can't quite remember the exact problem I was having. I went back to try and re-produce it, but can't now. IIRC it was the BUILD_TESTING check that was the key part (we building with testing disabled).

@saschazelzer
Copy link
Contributor

Thanks for the feedback. I also tried to reproduce a failure with various configuration options but couldn't. I would suggest to close the pull request and re-open it if you run into similar problems again.

@nocnokneo
Copy link
Author

Sounds good. Closed for now.

@nocnokneo nocnokneo closed this Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants