Separating mitkLookupTablePropertySerliazer into header and source #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rachel Sparks <rachel.sparks@ucl.ac.uk>
res191
force-pushed
the
bug-19255-mitkLookupTablePropertySerializer_Separate_Header_File
branch
from
2c1f75d
to
1b6c647
Compare
Signed-off-by: Rachel Sparks <rachel.sparks@ucl.ac.uk>
res191
force-pushed
the
bug-19255-mitkLookupTablePropertySerializer_Separate_Header_File
branch
from
1b6c647
to
2faabeb
Compare
…ader_File' of https://github.com/NifTK/MITK into bug-19255-mitkLookupTablePropertySerializer_Separate_Header_File Conflicts: Modules/SceneSerializationBase/include/mitkLookupTablePropertySerializer.h
|
Hi Rachel, thank you for your contribution. I merge it into the MITK master. However, your editor seems to be using tabs, which are not allowed in the master branch. I removed them, but that resulted in changing the author from you to me. Sorry about that. Again, many thanks for contributing! Best |
|
@swirkert You could have set the author again when committing your changes with the --author parameter, which is fine in a pure white space issue. I'm closing this pull request as it seems to be fixed in our master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rachel Sparks rachel.sparks@ucl.ac.uk