T22136, T22159: Fix for 3D-interpolation crash on closing plugin or deleting data #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KuznetsovAlexander <KuznetsovAlexander@rambler.ru>
Signed-off-by: KuznetsovAlexander <KuznetsovAlexander@rambler.ru>
Signed-off-by: KuznetsovAlexander <KuznetsovAlexander@rambler.ru>
KuznetsovAlexander
changed the title
|
Included by cherry-picking the three commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you close working data or segmentation plugin when 3d-interpolation is in progress, this will lead to crash. This happens because QFuture will still be running but there will be no data for it.
This PR adds waiting for future's complete before deleting node or closing plugin.
Signed-off-by: KuznetsovAlexander KuznetsovAlexander@rambler.ru