Avoid crashes in point picking when VTK props are deleted #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could observe crashes where mappers were deleted and subsequent picking was then attempting to access some of the deleted vtkProps associated to the deleted mappers. I do not see a way to improve the mtime checks in this method to avoid the aforementioned crash. So the only way to ensure proper picking seems to be the introduction of a new list of pointers to props so the props are not getting deleted. Signed-off-by: Daniel Maleike <daniel.maleike@stryker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could observe crashes where mappers were deleted and subsequent picking
was then attempting to access some of the deleted vtkProps associated
to the deleted mappers.
I do not see a way to improve the mtime checks in this method to avoid
the aforementioned crash. So the only way to ensure proper picking seems
to be the introduction of a new list of pointers to props so the props
are not getting deleted.
Signed-off-by: Daniel Maleike daniel.maleike@stryker.com