Fix moving items in data manager

[TrudbertSchwoerer]

When moving a node item in the data manager tree view and dropping it in between two items, not the parent of that two items was used as dropping destination but the grand parent.

[kislinsk]

Thanks for your PR. Can you elaborate more on how to reproduce this issue? I created a scene with a hierarchy of depth 3 and drag&dropping the grand children nodes works for me without them being attached to their grand parent nodes suddenly. If you want to drag and drop nodes to other parent nodes for example from one branch of a tree to another branch, make sure to enable "Data Manager > Allow changing of parent node" in the preferences first. Or is it a different issue?

[TrudbertSchwoerer]

The bug occurs when moving a data manager item in between two other items of the same parent. I know that this bug obviously does not occur when doing this in the MITK Workbench - although the item list of the parent collapses unexpectedly. It did also not occur in our MITK base application previously - but also the parent list was collapsed. We had a large refactoring of our application, and one change was that we now directly use a QTreeView which is then supplied with a QmitkDataStorageTreeModel via a QmitkDataStorageFilterProxyModel. We do no longer use the MITK supplied Data Manager View. I guess this is the reason why the bug occurs now in our Application. I saw in the debugger what happened and that the grand parent was selected, and from my understanding of the code this is a bug - and it fixes the bug in our application. My best guess is that this is an old bug and that somewhere in the Data Manager View there is a workaround for it (which maybe causes the parent list to collapse?). I raised a pull request in the hope that this might fix an old bug and potentially help removing a workaround such improving code quality, knowing that the bug does actually not happen when using the Data Manager View. Also, this will probably require a bit of research in the Data Manager View which I did not do because I don't use this class anymore.

…

________________________________ Von: Stefan Dinkelacker ***@***.***> Gesendet: Montag, 19. Februar 2024 08:34 An: MITK/MITK ***@***.***> Cc: Schwoerer, Trudbert ***@***.***>; Author ***@***.***> Betreff: Re: [MITK/MITK] Fix moving items in data manager (PR #280) Sie erhalten nicht oft eine E-Mail von ***@***.*** Erfahren Sie, warum dies wichtig ist<https://aka.ms/LearnAboutSenderIdentification> EXTERNAL EMAIL Thanks for your PR. Can you elaborate more on how to reproduce this issue? I created a scene with a hierarchy of depth 3 and drag&dropping the grand children nodes works for me without them being attached to their grand parent nodes suddenly. If you want to drag and drop nodes to other parent nodes for example from one branch of a tree to another branch, make sure to enable "Data Manager > Allow changing of parent node" in the preferences first. Or is it a different issue? — Reply to this email directly, view it on GitHub<#280 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDZKLALPVHR7WWE2WDOYZ3DYUL6AVAVCNFSM6AAAAABDJ5JMSWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRHA2TQMZZGQ>. You are receiving this because you authored the thread. CAUTION: External email. Do not click links or open attachments unless you recognize the sender and know the content is safe. Please forward all suspicious emails to ***@***.*** Follow this link to read our Privacy Statement<https://www.stryker.com/content/stryker/gb/en/legal/global-policy-statement.html/>