Merge pull request #104 from MITLibraries/97_switch_to_checkboxes

Switch from Select Multiple to Checkboxes

Gemfile

@@ -3,7 +3,8 @@ ruby '2.3.0'
 
 gem 'rails', '4.2.6'
 gem 'aws-sdk', '~> 2'
-gem 'bootstrap_form'
+gem 'bootstrap_form', git: 'https://github.com/MITLibraries/rails-bootstrap-forms',
+                      branch: 'use_parameterize_for_check_box_label_for'
 gem 'cancancan'
 gem 'delayed_job_active_record'
 gem 'devise'

Gemfile.lock

@@ -1,3 +1,10 @@
+GIT
+  remote: https://github.com/MITLibraries/rails-bootstrap-forms
+  revision: a666d4e3baf0b9f612a82a586e862bbe867793e9
+  branch: use_parameterize_for_check_box_label_for
+  specs:
+    bootstrap_form (2.3.0)
+
 GEM
   remote: https://rubygems.org/
   specs:
@@ -50,7 +57,6 @@ GEM
     aws-sdk-resources (2.2.28)
       aws-sdk-core (= 2.2.28)
     bcrypt (3.1.11)
-    bootstrap_form (2.3.0)
     builder (3.2.2)
     byebug (8.2.2)
     cancancan (1.13.1)
@@ -294,7 +300,7 @@ PLATFORMS
 DEPENDENCIES
   annotate
   aws-sdk (~> 2)
-  bootstrap_form
+  bootstrap_form!
   byebug
   cancancan
   coveralls

app/views/submissions/new.html.erb

@@ -15,10 +15,11 @@
                                label: 'Publication Date',
                                help: 'If not yet published, please enter an estimated Publication Date.'%>
 
-  <%= f.select :funders,
-      options_for_select(@submission.valid_funders, @submission.funders),
-      { include_hidden: false, help: 'Multiple funder selections are allowed' },
-      { multiple: true, size: 13 } %>
+  <%= f.form_group :funders, label: { text: 'Funders' } do %>
+    <% @submission.valid_funders.each do |funder| %>
+      <%= f.check_box(:funders, { multiple: true, label: funder }, funder, nil ) %>
+    <% end %>
+  <% end %>
 
   <%= f.file_field :documents, multiple: true,
                                help: 'Drag and Drop files or click "Choose Files"' %>

test/features/submission_create_pages_test.rb

@@ -23,7 +23,7 @@ def base_valid_form
     visit new_submission_path
     fill_in('Journal', with: 'Super Mega Journal')
     fill_in('Title', with: 'Alphabetical Order is Good Enough')
-    select 'Department of Energy (DOE)', from: 'submission_funders'
+    check('Department of Energy (DOE)')
     select '1999', from: 'submission[pub_date(1i)]'
     select 'January', from: 'submission[pub_date(2i)]'
     Timecop.return