Skip to content
This repository has been archived by the owner on Oct 16, 2020. It is now read-only.

Commit

Permalink
Merge pull request #99 from MITLibraries/91_wording_and_minor_tweaks
Browse files Browse the repository at this point in the history
91 wording and minor tweaks
  • Loading branch information
JPrevost committed Mar 17, 2016
2 parents f691512 + 595021c commit f6e8ada
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 10 deletions.
2 changes: 1 addition & 1 deletion app/models/submission.rb
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,6 @@ def submittable_funders

# Funders we want to display in the UI, but not include in {Mets}
def ui_only_funders
['None / Other']
['Other']
end
end
6 changes: 5 additions & 1 deletion app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@
<ul class="nav navbar-nav">
<li><%= link_to "New Submission", new_submission_path %></li>
<% if user_signed_in? %>
<li><%= link_to "Submissions", submissions_path %></li>
<% if current_user.admin? %>
<li><%= link_to "Submissions", submissions_path %></li>
<% else %>
<li><%= link_to "My Submissions", submissions_path %></li>
<% end %>
<li><%= link_to("Sign out", destroy_user_session_path, method: :delete, id: "sign_in") %></li>
<% else %>
<% if ENV['FAKE_AUTH_ENABLED'] == 'true' %>
Expand Down
13 changes: 10 additions & 3 deletions app/views/static/home.html.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
<h1>Hi!</h1>
<p>This is a Quick Submission form for MIT's Open Access Collection.</p>
<p><%= link_to('Federal research funders require', 'http://libraries.mit.edu/scholarly/publishing/research-funders/research-funder-open-access-requirements/') %>
articles they sponsor to be made openly accessible. Use this form to deposit
papers to MIT's Open Access Collection in relation to these requirements. You
will receive a persistent URL to give to your research funder(s), and your
article will be embargoed if required.</p>

<p>Get started with a <%= link_to('new submission', new_submission_path) %>.</p>
<p>DSpace submission forms remain available if you prefer.</p>

<p>If you're submitting an article under the MIT Open Access Policy instead of
in relation to funder requirements, there is a
<%= link_to('shorter form available', 'https://dspace.mit.edu/handle/1721.1/49433/submit') %>.</p>
9 changes: 4 additions & 5 deletions test/models/submission_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,15 @@ class SubmissionTest < ActiveSupport::TestCase

test 'valid with a ui only funder' do
sub = submissions(:sub_one)
sub.funders = ['None / Other']
sub.funders = ['Other']
assert sub.valid?
end

test 'funders_minus_ui_only_funders' do
sub = submissions(:sub_one)
sub.funders << 'None / Other'
assert_equal(sub.funders.include?('None / Other'), true)
assert_equal(sub.funders_minus_ui_only_funders.include?('None / Other'),
false)
sub.funders << 'Other'
assert_equal(sub.funders.include?('Other'), true)
assert_equal(sub.funders_minus_ui_only_funders.include?('Other'), false)
end

test 'valid with uri handle' do
Expand Down

0 comments on commit f6e8ada

Please sign in to comment.