This repository has been archived by the owner on Oct 16, 2020. It is now read-only.
26 direct s3 uploads #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes carrier wave and prepares model to expect to stream pdf from a URI into the zip file. This app currently only accepts PDFs so the mime type is hardcoded in mets.rb. If we change that, this will need to be adjusted.
Direct to S3 upload in the form via jQuery direct upload. - Submission Create no longer creates or submits packages Create needs to not be in the business of handling sword package creation and submission to dspace. Moving those outside of this scope will allow for much easier testing (and ultimately allow for a separate process to handle that out of band with the web interface). - We still work on a queuing jobs to create sword packages / deposit to dspace / read response / send emails In other words, this removed functionality that is required but will be added back in a separate commit to reduce the size and complexity of this already large and complex set of commits.
JPrevost
force-pushed
the
26_direct_s3_uploads
branch
from
2b18fd7
to
0551c8d
Compare
|
#21 will add tests and functionality to get the code coverage back up where it should be. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26
This removes sword deposits to dspace which will be added back under a separate ticket as this was getting too big.