update mapping for replacement

stakeholders suggest a change to the mapping to differentiate lost process fee from lost replacement fee
MITLibraries · Jan 30, 2024 · 3501ff4 · 3501ff4
1 parent 8f94ccb
commit 3501ff4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -53,7 +53,7 @@ uploaded to the bursar's system.
 | ---------------------- | ----------------------------------------- |
 | DAMAGEDITEMFINE        | Library damaged [barcode]                 |
 | LOSTITEMPROCESSFEE     | Library lost [barcode]                    |
-| LOSTITEMREPLACEMENTFEE | Library lost [barcode]                    |
+| LOSTITEMREPLACEMENTFEE | Library repl [barcode]                    |
 | OTHER                  | Library other [barcode]                   |
 | OVERDUEFINE            | Library overdue [barcode]                 |
 | RECALLEDOVERDUEFINE    | Library recalled [barcode]                |

diff --git a/lambdas/bursar_transfer.py b/lambdas/bursar_transfer.py
@@ -120,7 +120,7 @@ def generate_description(fine_fee_type: str, barcode: str) -> str:
     elif fine_fee_type == "LOSTITEMPROCESSFEE":
         mapped_type = "Library lost"
     elif fine_fee_type == "LOSTITEMREPLACEMENTFEE":
-        mapped_type = "Library lost"
+        mapped_type = "Library repl"
     elif fine_fee_type == "OVERDUEFINE":
         mapped_type = "Library overdue"
     elif fine_fee_type == "OTHER":

diff --git a/tests/fixtures/test.csv b/tests/fixtures/test.csv
@@ -1,9 +1,9 @@
 "MITID","STUDENTNAME","DETAILCODE","DESCRIPTION","AMOUNT","EFFECTIVEDATE","BILLINGTERM"
 "12345678","Transfer, Bursar","ROLH","Library overdue 39080036507785","123.45","03/01/2023","2023SP"
 "12345678","Transfer, Bursar","ROLH","Library overdue 39080036507785","0.82","03/01/2023","2023SP"
-"12345678","Transfer, Bursar","ROLH","Library lost 39080037379556","300","03/01/2023","2023SP"
+"12345678","Transfer, Bursar","ROLH","Library repl 39080037379556","300","03/01/2023","2023SP"
 "12345678","Transfer, Bursar","ROLH","Library overdue 39080037379556","1.45","03/01/2023","2023SP"
-"09876","The Beaver, Tim","ROLH","Library lost 39080002699707","100","03/01/2023","2023SP"
+"09876","The Beaver, Tim","ROLH","Library repl 39080002699707","100","03/01/2023","2023SP"
 "09876","The Beaver, Tim","ROLH","Library overdue 39080002699707","14","03/01/2023","2023SP"
 "09876","The Beaver, Tim","ROLH","Library other 39080002699707","10","03/01/2023","2023SP"
 "09876","The Beaver, Tim","ROLH","Library damaged 39080002699707","10","03/01/2023","2023SP"

diff --git a/tests/test_bursar_transfer.py b/tests/test_bursar_transfer.py
@@ -100,7 +100,7 @@ def test_billing_term(test_date, expected) -> None:
     "test_input,expected",
     [
         ({"type": "OVERDUEFINE", "barcode": "12345"}, "Library overdue 12345"),
-        ({"type": "LOSTITEMREPLACEMENTFEE", "barcode": "12345"}, "Library lost 12345"),
+        ({"type": "LOSTITEMREPLACEMENTFEE", "barcode": "12345"}, "Library repl 12345"),
         ({"type": "LOSTITEMPROCESSFEE", "barcode": "12345"}, "Library lost 12345"),
         ({"type": "RECALLEDOVERDUEFINE", "barcode": "12345"}, "Library recalled 12345"),
         ({"type": "DAMAGEDITEMFINE", "barcode": "12345"}, "Library damaged 12345"),