Ensy 187 bursar transfer success email from bursar transfer lambda should include number of lines and total charges #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uploading the .csv to CHASS, the operator is required to fill in form fields with the total of all the charges being submitted, and the number of records in the input file. * calculates total charges and record count * returns these values in the dict which the step function can access so they can be included in the success email. Step function email needs to be updated to take advantage of these new values * https://mitlibraries.atlassian.net/browse/ENSY-187
ghukill
requested changes
Sep 21, 2023
* Add docstring * Add rounding to sum of charges * changed record count variable name to add clarity to what it represents. * changed record count key in return dict this will require a corresponding change in the step function definition.
adamshire123
force-pushed
the
ENSY-187-bursar-transfer-success-email-from-bursar-transfer-lambda-should-include-number-of-lines-and-total-charges
branch
from
276c76d
to
211e52a
Compare
ehanson8
reviewed
Sep 25, 2023
adamshire123
deleted the
ENSY-187-bursar-transfer-success-email-from-bursar-transfer-lambda-should-include-number-of-lines-and-total-charges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds record count and total amount of charges to the values returned by the lambda
so that these value can be included in the success email triggered by the step function
Helpful background context
The CHASS webform has required fields for total records and total charges when submitting
a file. We should send these value in the success email so that staff don't have to open the
datafile and calculate them.
How can a reviewer manually see the effects of these changes?
follow the local testing instruction in the readme. observe new return values.
Includes new or updated dependencies?
YES
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/ENSY-187
Developer
Code Reviewer
(not just this pull request message)