Bump python 3.12 and maintenance updates #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: Some new CLI application project structures, linting, and testing conventions were established in 2023. This is the first time this project has receieved maintenance updates since that time. Additionally, this commit bumps the python version to 3.12. How this addresses that need: * Bumps python version in required areas * Establishes new linting and testing conventions * Updates files to meet new linting requirements Side effects of this change: * None Relevant ticket(s): * None
ehanson8
approved these changes
Jun 11, 2024
|
FYI @ehanson8 , @jonavellecuerdo - new commits based on code review suggestions. |
ehanson8
approved these changes
Jun 11, 2024
|
Tested with sample data in stage environment. LGTM. |
adamshire123
approved these changes
Jun 12, 2024
jonavellecuerdo
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bumps python version to 3.12, and updates structure of project linting and testing to new conventions.
Most changes were syntactical to meet new linting requirements, but a couple of repeated changes are somewhat meaningful:
datetimeobjects are now UTC timezone awaredatetime.datetime(...)was used, now includestzinfo=datetime.UTCdatetime.strptime(...)is used,.replace(tzinfo=datetime.UTC)is included to replace the timezone with UTC, but keep the original 00:00 hours/minutes when parsing theYYYY-MM-DDdate string without hours or minutes presenttzinfo=...was used, this would bump the hours +4 hours to UTC time upon parsing, which while likely inconsequential, is not ideal, given theYYYY-MM-DDtimestamp has no notion of hours or minutesNOTE: Testing has not yet been confirmed in Dev1 or Stage. This will happen with help from @adamshire123 before a release is tagged.
Helpful background context
This project was using python 3.11 before this PR, and had not receieved any maintenance updates to match new patterns for linting and testing established recently.
How can a reviewer manually see the effects of these changes?
Tests run, linting passes.
As mentioned above, manual integration tests that require access to Terraform and Alma console will be performed with help from @adamshire123 (or someone else with access).
Includes new or updated dependencies?
YES
What are the relevant tickets?
None
Developer
Code Reviewer
(not just this pull request message)