Alma job names handling #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: We changed some configurations in AWS so that the job names are all stored in SSM. Because of this we can include the AWS environment in the job name, which should be the complete job name for POD and Bursar jobs, TIMDEX is an exception. The TIMDEX job name should include the AWS environment, but is still technically a prefix because TIMDEX job names end with the type (full or daily), but we don't want to have two separate environment variables for each of those job types. How this addresses that need: * Updated readme * Changed the name of the bursar job name env variable * Reordered the check for matching environments to come first * updated the tests to use the new variable name * updated the tests to inclue the environment name in test environment variables
ehanson8
requested changes
Aug 29, 2023
| @@ -29,6 +29,10 @@ | |||
| logger.info("No Sentry DSN found, exceptions will not be sent to Sentry") | |||
|
|
|||
|
|
|||
| class JobTypeError(Exception): | |||
There was a problem hiding this comment.
Typos for unknown and received
ghukill
approved these changes
Aug 29, 2023
| @@ -29,6 +29,10 @@ | |||
| logger.info("No Sentry DSN found, exceptions will not be sent to Sentry") | |||
|
|
|||
|
|
|||
| class JobTypeError(Exception): | |||
There was a problem hiding this comment.
I like this explicit exception type here.
Pull Request Test Coverage Report for Build 6015629858
💛 - Coveralls |
ehanson8
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports storing job names in SSM and including the AWS environment as part of the job name
Includes new or updated dependencies?
YES
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/ENSY-178
Developer
Code Reviewer