Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency and linting updates #187

Merged
merged 2 commits into from
Feb 12, 2024
Merged

dependency and linting updates #187

merged 2 commits into from
Feb 12, 2024

Conversation

adamshire123
Copy link
Contributor

@adamshire123 adamshire123 commented Feb 12, 2024

What does this PR do?

updates dependencies
fixes linting problems

Includes new or updated dependencies?

YES

Developer

  • All new ENV is documented in README
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7873611060

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6125066606: 0.0%
Covered Lines: 140
Relevant Lines: 140

💛 - Coveralls

@adamshire123 adamshire123 changed the title dependency updates dependency and linting updates Feb 12, 2024
Copy link
Contributor

@ghukill ghukill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Left a comment about the major version bump for urllib3 going from version 1.26.16 to 2.0.7, but assuming tests passed, imagine that's okay.

Comment on lines -185 to +201
"markers": "python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5'",
"version": "==1.26.16"
"markers": "python_version >= '3.7'",
"version": "==2.0.7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this major version change for urllib3 from 1.26.16 to 2.0.7, assuming all the tests ran okay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in slack, not seeing anything in the 2.x changelog that would suggest this version bump would be problematic: https://github.com/urllib3/urllib3/blob/main/CHANGES.rst#L88-L114.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of the extra integration tests passed

@adamshire123 adamshire123 merged commit e03e287 into main Feb 12, 2024
3 checks passed
@adamshire123 adamshire123 deleted the dependency-updates branch February 12, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants