-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dependency and linting updates #187
Conversation
Pull Request Test Coverage Report for Build 7873611060Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Left a comment about the major version bump for urllib3
going from version 1.26.16
to 2.0.7
, but assuming tests passed, imagine that's okay.
"markers": "python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2, 3.3, 3.4, 3.5'", | ||
"version": "==1.26.16" | ||
"markers": "python_version >= '3.7'", | ||
"version": "==2.0.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this major version change for urllib3
from 1.26.16
to 2.0.7
, assuming all the tests ran okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in slack, not seeing anything in the 2.x
changelog that would suggest this version bump would be problematic: https://github.com/urllib3/urllib3/blob/main/CHANGES.rst#L88-L114.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of the extra integration tests passed
What does this PR do?
updates dependencies
fixes linting problems
Includes new or updated dependencies?
YES
Developer
Code Reviewer