Maintenance week updates

[jonavellecuerdo]

What does this PR do?

Update app according to DataEng Application Maintenance. Here are some changes worth noting:

• Update application to Python 3.12
  • All unit tests, including integration tests are passing 🎉
• Address minimal linting errors
  • Update syntax in pyproject.toml
  • Address ruff rule violation for E501 in conftest.py
• Clean up Makefile
• Update README (Development and Environment Variables section)

How can a reviewer manually see the effects of these changes?

1. Run make test and verify all unit tests are passing.
2. Run integration tests and verify all integration tests are passing.

Includes new or updated dependencies?

YES

Developer

• All new ENV is documented in README
• Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

• The commit message is clear and follows our guidelines (not just this pull request message)
• There are appropriate tests covering any new functionality
• The documentation has been updated or is unnecessary
• The changes have been verified
• New dependencies are appropriate or there were no changes

[coveralls]

Pull Request Test Coverage Report for Build 9375162046

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 8103188080:	0.0%
Covered Lines:	140
Relevant Lines:	140

---

💛 - Coveralls

[ghukill]

I got nothing, looks good! Able to run tests, lenting, and integration tests locally.

Feel additionally confident given that the python 3.12 actually used is an image public.ecr.aws/lambda/python:3.12 created by AWS, for Lambdas, so expect it to work well.

[ghukill]

Two thoughts:

1- Appreciate the centralization and moving of these here

2- While it's a lot of text... I still think I like it. As a developer, for example, I have the option of multiple-cursors and can quickly clear the comments. Or, if I'm InfraEng (and curious what they actually think) I can see all the env vars quickly as a list for confirming they are set as needed in terraform.

[coveralls]

Pull Request Test Coverage Report for Build 9401857322

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 100.0%

---

Totals
Change from base Build 8103188080:	0.0%
Covered Lines:	140
Relevant Lines:	140

---

💛 - Coveralls

[jonavellecuerdo]

• timdex-ingest-prod state machine completed successfully for the Alma daily run ✨

• Received an email notification that a PPOD upload completed successfully ✨