Update To New Tf Workflows #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: The build/deploy workflows in our shared .github repository for Lambda functions and Fargate tasks have been cleaned up and consolidated. The mitlib-tf-workloads-ecr repository that generates the text for the three caller workflows has been updated and we just need to move those Terraform outputs into this repository to update the caller workflows. How this addresses that need: * Update three caller workflows to use the new outputs from the mitlib-tf-workloads-ecr repository Side effects: None. Resolves #58
cabutlermit
requested review from
zotoMIT,
hakbailey and
a team
and removed request for
zotoMIT and
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Helpful background context
The build/deploy workflows in our shared .github repository for Lambda functions and Fargate tasks have been cleaned up and consolidated. The mitlib-tf-workloads-ecr repository that generates the text for the three caller workflows has been updated and we just need to move those Terraform outputs into this repository to update the caller workflows.
How can a reviewer manually see the effects of these changes?
The developer can manually trigger the
dev-build.ymlworkflow (from this branch) in the Actions tab to verify that the caller workflow properly pushes the updated container to the Dev1 AWS Account. Because the changed files live in a folder that is ignored by the workflow triggers, none of the workflows should get automatically triggered. Or, the developer can review the workflow run that was triggered manually by me.Includes new or updated dependencies?
NO
Developer
Code Reviewer