PR4 - Add CI and AWS terraform #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: This final PR adds Github CI actions and terraform code to project. This was formerly in place, but removed during the full PR review process. How this addresses that need: * adds .github folder * adds terraform generated AWS CLI commands to Makefile * adds convenience Makefile command to run a test harvest in Dev1 Side effects of this change: * Github actions now fire Relevant ticket(s): https://mitlibraries.atlassian.net/browse/TIMX-247
jonavellecuerdo
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This final PR adds Github CI actions and terraform code to project. This was formerly in place, but removed during the full PR review process.
Helpful background context?
After this PR is approved and merged, the retroactive code review process will be complete. The next step will be to force update the
mainbranch with thecode-review-mainbranch that's been used. This may or may not be a PR, as it might be ultimately easier to perform directly this via a git CLI command.UPDATE: Working to force update
main, and will update the target of this PR to go into main. This shouldn't affect the code review, just some git gymnastics after failing to reset the git history of the template when originally cloned.UPDATE:
mainhas been force reset to matchpr3-parser, and this PR has been updated to merge intomain. Thecode-review-mainbranch is no longer needed.How can a reviewer manually see the effects of these changes?
With this CI and AWS scaffolding added, it's possible to run a test harvest in the Dev1 environment.
If required / desired, you can publish a new image (though the creation of this PR has accomplished this):
The following Makefile command will kick off an ECS task to run a harvest in Dev1:
If you have the AWS CLI installed, you can monitor the logs of the harvest:
The final output should be two new files in the TIMDEX S3 bucket. Using the
TimdexManagerrole, you can navigate to bucket + folder:s3://timdex-extract-dev-222053980223/librarywebsite/and look for files with pattern:test-harvest-ecs-2023-10-13.wacztest-harvest-ecs-2023-10-13.xmlIncludes new or updated dependencies?
NO
What are the relevant tickets?
https://mitlibraries.atlassian.net/browse/TIMX-247
Developer
Code Reviewer
(not just this pull request message)