Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timx 247 initial build #2

Closed
wants to merge 22 commits into from
Closed

Timx 247 initial build #2

wants to merge 22 commits into from

Conversation

ghukill
Copy link
Collaborator

@ghukill ghukill commented Sep 25, 2023

What does this PR do?

Initial PR for this new CLI application. Tests the build process of deploying a new ECR image, which can be invoked as ECS task from the new image.

Helpful background context

This application will be used in the TIMDEX pipeline to perform web crawls of library websites and extract structured data from those crawls that is suitable for transformation and inclusion in TIMDEX.

Includes new or updated dependencies?

YES

What are the relevant tickets?

https://mitlibraries.atlassian.net/browse/TIMX-247

Developer

  • All new ENV is documented in README (or there is none)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

  • The commit message is clear and follows our guidelines
    (not just this pull request message)
  • There are appropriate tests covering any new functionality
  • The documentation has been updated or is unnecessary
  • The changes have been verified
  • New dependencies are appropriate or there were no changes

ghukill and others added 22 commits September 21, 2023 13:57
Why these changes are being introduced:
The ECR repositories have been deployed in all three environments in
AWS. This updates the app repo with the associated deployment automation
workflows.

How this addresses that need:
* Add the `stage-build` workflow from the mitlib-tf-workloads-ecr repo
* Add the `prod-promote` workflow from the mitlib-tf-workloads-ecr repo
* Minor formatting changes to the Makefile (to put the Tf-generated
header at the top of the file)

Side effects of this change:
Merges to the `main` branch will now automatically deploy to
Stage-Workloads. Tagged releases on the `main` branch will
automatically deploy to Prod-Workloads.

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/TIMX-248
Why these changes are being introduced:
Using 'harvest' continues to reinforce that this application is more than just
a browsertrix web crawl, but also a metadata parsing process.  This is also more
inline with the OAI-PMH harvester in naming conventions.
@ghukill ghukill closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants