Skip to content

Commit

Permalink
Fix for Oracle ZIP Location
Browse files Browse the repository at this point in the history
Why these changes are being introduced:
The previous Makefile had a hardcoded name for an S3 bucket that holds
a copy of the Oracle library .zip file. This makes that S3 bucket name
dynamic to match the dev/stage/prod account from which it should be
pulled.

How this addresses that need:
* Update the environment variable definitions in the Makefile

Side effects of this change:

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-615
  • Loading branch information
cabutlermit committed Oct 26, 2022
1 parent b43351c commit b2b480f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Expand Up @@ -10,8 +10,8 @@ ECR_URL_DEV:=222053980223.dkr.ecr.us-east-1.amazonaws.com/carbon-dev
### End of Terraform-generated header ###

SHELL=/bin/bash
S3_BUCKET=shared-files-222053980223
ORACLE_ZIP=instantclient-basiclite-linux.x64-18.3.0.0.0dbru.zip
S3_BUCKET:=shared-files-$(shell aws sts get-caller-identity --query "Account" --output text)
ORACLE_ZIP:=instantclient-basiclite-linux.x64-18.3.0.0.0dbru.zip
DATETIME:=$(shell date -u +%Y%m%dT%H%M%SZ)

help: ## Print this message
Expand Down

0 comments on commit b2b480f

Please sign in to comment.