Add support for FTPing XML to server #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an alternative output option for the generated XML feed, allowing it to be sent out over FTPS. It is in preparation for moving this to an AWS Lambda. The size of the Academic Analytics feed can get pretty big, and given the constraints of Lambda, this uses a Unix pipe to buffer the XML. I'm leaving the existing CLI in place because it makes it easier to test out in development. This also drops old versions of Python from the test suite. Although the FTP server used for testing claims to support 2.6+, the TLS support wasn't working in 2.7. Lambda uses 3.6 anyways.
|
Oh, also, yes, I am aware this commit includes a cert+key pair. |
JPrevost
reviewed
Jul 23, 2018
| for article in articles(): | ||
| f(article) | ||
| if ftp: | ||
| r, w = os.pipe() |
There was a problem hiding this comment.
Just a comment and there may be very good reasons for not doing this, but it might be nice to move this setup code to the PipeWriter class to make this if as clean as the else for ease of reading.
There was a problem hiding this comment.
Hmm. Since it's reading all the CLI switches it's probably not clean to do that. Oh well.
hakbailey
approved these changes
Jul 23, 2018
JPrevost
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an alternative output option for the generated XML feed,
allowing it to be sent out over FTPS. It is in preparation for moving
this to an AWS Lambda.
The size of the Academic Analytics feed can get pretty big, and given
the constraints of Lambda, this uses a Unix pipe to buffer the XML. I'm
leaving the existing CLI in place because it makes it easier to test out
in development.
This also drops old versions of Python from the test suite. Although the
FTP server used for testing claims to support 2.6+, the TLS support
wasn't working in 2.7. Lambda uses 3.6 anyways.