Update docs and Makefile to reflect Fargate deploy #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the documents for the current Fargate deployment process. The Makefile has also been modified to account for the production deployment. Actually promoting the staging build to production will require (minimal) manual intervention.
JPrevost
reviewed
Jan 29, 2019
| 1. Make your changes. | ||
| 2. Run ``make dist`` from project root. | ||
| 3. Test your changes by running ``docker run --rm carbon <carbon args>``, with ``<carbon args>`` being whatever arguments you would normally use to run carbon. | ||
|
|
There was a problem hiding this comment.
I can't comment on the bit I want to because it's not in this changes... under Building it mentions:
Running ``make dist`` creates a new container that is tagged as ``carbon:latest``. is that still accurate?
JPrevost
reviewed
Jan 29, 2019
|
|
||
| When you are ready to deploy the current staging build to production, simply run:: | ||
|
|
||
| $ make promote |
JPrevost
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documents for the current Fargate deployment process.
The Makefile has also been modified to account for the production
deployment. Actually promoting the staging build to production will
require (minimal) manual intervention.