Tests and Python Upgrade #4
Conversation
Why these changes are being introduced: Update the testing functions to address the three different input json files (standard cdn, future-of-libraries custom domain, grandchallenges custom domain). Fix a typo in the Makefile How this addresses that need: * Clean up the json fixtures to match what's happening in the CDN * Add testing functions for the standard CDN and the Grand Challenges site * Clean up the testing function for Future of Libraries site Side effects of this change: None.
Why these changes are being introduced: With the updates to mitlib-tf-workloads-libraries-website, Terraform and the AWS Provider now support Python 3.11 for Lambda and Lambda@Edge. How this addresses that need: * Update the Python version to 3.11 Side effects of this change: None. Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-106
|
@JPrevost I'm tagging you for a review so that you can follow along with the automated deployment behavior when it merges. There isn't much to actually approve here. 😁 |
There was a problem hiding this comment.
I suspect this is an oddity in the shared workflow this uses, but tests run twice because it runs make test which runs the tests as well as make coveralls which runs make test before it runs. It may be a minor thing as these tests are fast, but repos that have extensive test suites running twice would be annoying. The shared workflow this inherits from should likely consider just running make coveralls to avoid double test runs in CI.
ah, crud. just realized that I had forgotten to uncomment the automation piece of stage workflow before submitting this PR! I'm going to push one more commit... |
Why these changes are being introduced: This turns on the automated trigger (on.push) for merge to `main`. How this addresses that need: * Uncomment the `on.push` workflow trigger for the deploy to Stage Side effects of this change: Merge to `main` will now automatically trigger deploys to Stage-Workloads
Pull Request Test Coverage Report for Build 7558825715
💛 - Coveralls |
Purpose and background context
A few minor changes: this adds additional tests to verify that the code processes the
origin-requestJSON objects correctly, it updates the Python version to 3.11 to match what is now available in AWS with the update AWS Provider in Terraform, and it removes any Sentry references since we don't use Sentry in Lambda@Edge functions (for now?).Additionally, this PR (and its eventual merge to
mainwill be a test of the automated deployment of the Lambda function in Stage-Workloads. This code is already running in Stage-Workloads as part of the infrastructure updates and verifying that themake upload-zipcommand can write a file to the Stage-Workloads S3shared-files-xxxxbucket. Once this PR is approved, we'll track the automation behavior when it is merged tomain.How can a reviewer manually see the effects of these changes?
make teststo see all the tests runIncludes new or updated dependencies?
YES: Updates Python version to 3.11 and removes Sentry dependency.
Changes expectations for external applications?
NO
What are the relevant tickets?
Developer
Dev CF Lambda@Edge Full Deployworkflow has been run to update CloudFront in Dev1Code Reviewer(s)