Skip to content

Commit

Permalink
Minor changes based on PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
hakbailey committed Sep 23, 2021
1 parent c7822e0 commit 6255aa4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"smart-open",
(
"dspace-python-client @ git+https://github.com/mitlibraries/"
"dspace-python-client@0.1.0#egg=dspace"
"dspace-python-client@0.1.0#egg=dspace-python-client"
),
],
entry_points={"console_scripts": ["submitter=submitter.cli:main"]},
Expand Down
8 changes: 4 additions & 4 deletions submitter/sqs.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

def message_loop(queue, wait):
logger.info("Message loop started")
msgs = retrieve(queue, wait)
msgs = retrieve_messages_from_queue(queue, wait)

if len(msgs) > 0:
process(msgs)
Expand All @@ -35,7 +35,7 @@ def process(msgs):
# TODO: handle and test submit message errors
raise e
submission.submit(client)
write(
write_message_to_queue(
submission.result_attributes,
json.dumps(submission.result_message),
submission.result_queue,
Expand All @@ -46,7 +46,7 @@ def process(msgs):
logger.info("Deleted message %s from input queue", message_id)


def retrieve(input_queue, wait):
def retrieve_messages_from_queue(input_queue, wait):
sqs = boto3.resource("sqs")
queue = sqs.get_queue_by_name(QueueName=input_queue)

Expand All @@ -62,7 +62,7 @@ def retrieve(input_queue, wait):
return msgs


def write(attributes, body, output_queue):
def write_message_to_queue(attributes, body, output_queue):
sqs = boto3.resource("sqs")
queue = sqs.get_queue_by_name(QueueName=output_queue)
queue.send_message(
Expand Down

0 comments on commit 6255aa4

Please sign in to comment.