Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes necessary to get site running with Lando #475

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matt-bernhardt
Copy link
Member

@matt-bernhardt matt-bernhardt commented Sep 20, 2022

Why are these changes being introduced:

  • There are some dependency updates which need to be applied
  • The site lacks a .lando.yml file to allow developers to run it locally.

Relevant ticket(s):

How does this address that need:

  • This adds the .lando.yml file that is generated when running lando init
  • It also updates the Composer files (lock and json) to allow the site to start successfully.

Document any side effects to this change:

  • I think this will end up encompassing the pending dependency updates.

Developer

  • All new secrets documented in README
  • All new secrets have been added to Pantheon tiers
  • ANDI or Wave has been run in accordance to
    our guide and
    all issues introduced by these changes have been resolved or opened as new
    issues (link to those issues in the Pull Request details above)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer

Dependency updates do not get code review

Includes new or updated dependencies?

YES

** Why are these changes being introduced:

* There are some dependency updates which need to be applied
* The site lacks a .lando.yml file to allow developers to run it
  locally.

** Relevant ticket(s):

* n/a

** How does this address that need:

* This adds the .lando.yml file that is generated when running
  `lando init`
* It also updates the Composer files (lock and json) to allow the site
  to start successfully.

** Document any side effects to this change:

* I think this will end up encompassing the pending dependency updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant