-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation #1
base: main
Are you sure you want to change the base?
Conversation
441a71e
to
bf7b0d7
Compare
bf7b0d7
to
2d07ea7
Compare
2d07ea7
to
0cd4531
Compare
0cd4531
to
beedd22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good diagrams that provide the proper context on expected workflow, looking forward to the discussion tomorrow!
docs/entity_relationship_diagram.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful for establishing the context of this workflow!
@@ -0,0 +1,74 @@ | |||
# Publication Email Request Service (PERS) | |||
|
|||
The following are sequence diagrams describing the workflow for sending publication email requests with this service. At high-level the steps involved are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor and optional, but maybe email requests for publications
for clarity
|
||
The following are sequence diagrams describing the workflow for sending publication email requests with this service. At high-level the steps involved are: | ||
|
||
1. Import citations for authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional rephrasing to improve clarity (but please correct if I'm getting it wrong!):
1. Import Publication citations for Authors to database
2. Create emails requesting the Publications based on the citations
3. Review and (optionally) update emails
4. Send emails to Liaisons who will send them to Authors
* When an `Email` is created, it is assigned to **one** `Author` and **one** `Liaison`. | ||
The entities involved in PERS are as follows: | ||
|
||
* `DLC`: Represents a department, lab, or center at MIT and is managed by a single **liaison**. A **DLC** can comprise of many **authors**, but an author is assigned to a single **DLC**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra detail is very helpful
Purpose and background context
Add documentation describing the Publication Email Request Service (PERS) workflow. These diagrams were created from reviewing the existing Solenoid workflow and data models.
What are the relevant tickets?
Developer
Code Reviewer(s)