Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation #1

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

add documentation #1

wants to merge 3 commits into from

Conversation

jonavellecuerdo
Copy link
Collaborator

@jonavellecuerdo jonavellecuerdo commented Apr 26, 2024

Purpose and background context

Add documentation describing the Publication Email Request Service (PERS) workflow. These diagrams were created from reviewing the existing Solenoid workflow and data models.

What are the relevant tickets?

Developer

  • All new ENV is documented in README
  • All new ENV has been added to staging and production environments
  • All related Jira tickets are linked in commit message(s)
  • Stakeholder approval has been confirmed (or is not needed)

Code Reviewer(s)

  • The commit message is clear and follows our guidelines (not just this PR message)
  • There are appropriate tests covering any new functionality
  • The provided documentation is sufficient for understanding any new functionality introduced
  • Any manual tests have been performed or provided examples verified
  • New dependencies are appropriate or there were no changes

@jonavellecuerdo jonavellecuerdo changed the title create entity relationship diagram add documentation Apr 26, 2024
Copy link
Collaborator

@ehanson8 ehanson8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good diagrams that provide the proper context on expected workflow, looking forward to the discussion tomorrow!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful for establishing the context of this workflow!

@@ -0,0 +1,74 @@
# Publication Email Request Service (PERS)

The following are sequence diagrams describing the workflow for sending publication email requests with this service. At high-level the steps involved are:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor and optional, but maybe email requests for publications for clarity


The following are sequence diagrams describing the workflow for sending publication email requests with this service. At high-level the steps involved are:

1. Import citations for authors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional rephrasing to improve clarity (but please correct if I'm getting it wrong!):

1. Import Publication citations for Authors to database
2. Create emails requesting the Publications based on the citations
3. Review and (optionally) update emails
4. Send emails to Liaisons who will send them to Authors

* When an `Email` is created, it is assigned to **one** `Author` and **one** `Liaison`.
The entities involved in PERS are as follows:

* `DLC`: Represents a department, lab, or center at MIT and is managed by a single **liaison**. A **DLC** can comprise of many **authors**, but an author is assigned to a single **DLC**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra detail is very helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants