Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sentry-raven: 3.0.0 → 3.1.0 (minor) #502

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Sep 18, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ sentry-raven (3.0.0 → 3.1.0) · Repo · Changelog

Release Notes

3.1.0

Feature

  • Exclude all 4xx Rails errors (#1004)

    See the full list here

  • Add some error context in transport_failure_callback (#1003)

    Before:

    config.transport_failure_callback = lambda { |event|
      AdminMailer.email_admins("Oh god, it's on fire!", event).deliver_later
    }

    After:

    config.transport_failure_callback = lambda { |event, error|
      AdminMailer.email_admins("Oh god, it's on fire because #{error.message}!", event).deliver_later
    }
  • Support cleaning up exception backtrace with customized backtrace_cleaner (#1011)

    The new config backtrace_cleanup_callback takes a lambda/proc object (default is nil) and will be called with exception's backtrace

    Raven.configure do |config|
      config.backtrace_cleanup_callback = lambda do |backtrace|
        Rails.backtrace_cleaner.clean(backtrace)
      end
    end

    And with the Rails integration, it'll automatically use a customized Raven::Rails::BacktraceCleaner to clean up exception's backtrace. It's basically Rails 6's backtrace cleaner but without silencers.

    The main reason to add this cleaner is to remove template methods from the trace, e.g.

    app/views/welcome/view_error.html.erb in _app_views_welcome_view_error_html_erb__2807287320172182514_65600 at line 1
    

    will become

    app/views/welcome/view_error.html.erb at line 1
    

    This can help Sentry group issues more accurately. See #957 for more information about this.

    If you don't want this change, you can disable it with:

    Raven.configure do |config|
      config.backtrace_cleanup_callback = nil
    end
  • Make dsn value accessable from config (#1012)

    You can now access the dsn value via Raven.configuration.dsn

Deprecation

  • Deprecate dasherized filenames (#1006)

    If you're using

    gem 'sentry-raven', require: 'sentry-raven-without-integrations'
    # or 
    require "sentry-raven-without-integrations"

    you will start seeing deprecation warnings. Please change them into

    gem 'sentry-raven', require: 'sentry_raven_without_integrations'
    # or 
    require "sentry_raven_without_integrations"
  • Unify breadcrumb loggers activation (#1016)

    Currently, we activate our breadcrumb loggers differently:

    require "raven/breadcrumbs/sentry_logger"
    Raven.configuration.rails_activesupport_breadcrumbs = true

    It's not a nice user interface, so this PR adds a new configuration
    option breadcrumbs_logger to improve this:

    Raven.configuration.breadcrumbs_logger = :sentry_logger
    Raven.configuration.breadcrumbs_logger = :active_support_logger
    Raven.configuration.breadcrumbs_logger = [:sentry_logger, :active_support_logger]

    Please migrate to the new activation apporach, otherwise you'll see depraction warnings. And old ones will be dropped in version 4.0.

Refactor

  • Accept non-string message in Event.from_exception (#1005)
  • Refactor event initialization (#1010)
  • Refactor sidekiq integration (#1019)

Fix

  • Replace sys_command usages in context.rb (#1017)
  • Fix merge error from rack-timeout raven_context on old releases (#1007)
  • Return value of rescue_with_handler when intercepting ActiveJob exceptions (#1027)

3.0.4

  • fix: Don't log warning messages when it doesn't need to (#1000)
  • fix: Revert "Refactor Raven::Client class" (#1002)

3.0.3

  • fix: Ensure Processor::Cookie can run after Processor::RemoveCircularReferences (#996)
  • fix: Avoid mutating user passed in options (#994)
  • fix: Fix/Refactor Raven::Cli (#989)
  • ref: Refactor Raven::Client class (#995)
    • It adds Event#message_from_exception and Event#log_message interfaces

3.0.2

  • fix: Add gem target for craft

3.0.1

  • fix: Improve SanitizeData processor (#984)
  • fix: Masking cookies as key/pair instead of a single string (#983)
  • fix: Transports classes' requiring issue (#986)
  • fix: Frozen string issues (#977)
  • feat: Officially support Rails 6 (#982)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.386% when pulling ed425f4 on depfu/update/sentry-raven-3.1.0 into 3dd2544 on master.

@depfu
Copy link
Contributor Author

depfu bot commented Sep 26, 2020

Closed in favor of #505.

@depfu depfu bot closed this Sep 26, 2020
@depfu depfu bot deleted the depfu/update/sentry-raven-3.1.0 branch September 26, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants