Add new geo alias for gismit and gisogm sources #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why these changes are being introduced: With the addition of new sources 'gismit' and 'gisogm', it has been decided these sources will also funnel into a new alias called 'geo'. This alias will provide a geo-only index for powering a geo focused UI. How this addresses that need: * Adds new 'geo' alias and sources that map to this alias Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/GDT-92
Pull Request Test Coverage Report for Build 7389158466
💛 - Coveralls |
ehanson8
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds new
geoalias and sources that map to this aliasHelpful background context
With the addition of new sources
gismitandgisogm, it has been decided these sources will also funnel into a new alias calledgeo. This alias will provide a geo-only index for powering a geo focused UI.How can a reviewer manually see the effects of these changes?
Not currently possible without other supporting changes in TIMDEX pipeline. These changes will result in additioanl indexing commands getting sent to
timdex-index-manager(TIM) for managing indexes in OpenSearch.Includes new or updated dependencies?
YES
What are the relevant tickets?
Developer
Code Reviewer
(not just this pull request message)