Skip to content

Commit

Permalink
Accommodate multi-digit list markers
Browse files Browse the repository at this point in the history
Why these changes are being introduced:

The result list does not have a sufficient left margin to
accommodate list markers that are more than one digit. Because
of this, markers for results further down in the list are
truncated.

This issue exists on smaller viewports only. Larger viewports
have enough space for markers up to five digits. (This is the
maximum, in our case.)

Relevant ticket(s):

* [GDT-314](https://mitlibraries.atlassian.net/browse/GDT-314)

How this addresses that need:

This adds a left margin on smaller viewports to accommodate
5-digit result markers, and removes the result padding to provide
more room for text flow.

Side effects of this change:

The margin is somewhat excessive for 1- or 2-digit numbers, but
it seems like a reasonable tradeoff for now.
  • Loading branch information
jazairi committed May 28, 2024
1 parent dbcbc68 commit 5b16f11
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions app/assets/stylesheets/partials/_results.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@
margin-top: 0;
}
}

.results-list {
@media (max-width: $bp-screen-md) {
.result {
padding-left: 0;
padding-right: 0;
margin-left: 3rem;
}
}
}
}

.result {
Expand Down

0 comments on commit 5b16f11

Please sign in to comment.