Skip to content

Commit

Permalink
Implement UX feedback on access link sidebar
Browse files Browse the repository at this point in the history
Why these changes are being introduced:

UXWS has requested some changes to the access link sidebar (and
the full record view more broadly).

Relevant ticket(s):

* [GDT-319](https://mitlibraries.atlassian.net/browse/GDT-319)

How this addresses that need:

* Changes aria-label for the sidebar;
* Updates heading typography to match the filter sidebar heading; and
* Adds top margin to the full record.

Side effects of this change:

None.
  • Loading branch information
jazairi committed May 14, 2024
1 parent dbcbc68 commit dc54ccf
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion app/assets/stylesheets/partials/_record.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
.wrap-full-record {
margin-top: 2.4rem;

.record-title {
font-size: 2.5rem;
line-height: 1.1;
Expand Down Expand Up @@ -48,7 +50,7 @@
}

.return-to-results {
padding: 1.5% 0;
padding-top: 2.4rem;
a {
padding: 1.5%;
color: $blue;
Expand All @@ -68,5 +70,8 @@
}

.access-sidebar {
@media (max-width: $bp-screen-md) {
margin-top: 2.4rem;
}
padding-top: 3%;
}
4 changes: 2 additions & 2 deletions app/views/record/_sidebar.html.erb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<% if Flipflop.enabled?(:gdt) %>
<div role="region" aria-label="Access links and additional information" class="col1q-r sidebar access-sidebar">
<div role="region" aria-label="Access and help links" class="col1q-r sidebar access-sidebar">
<% else %>
<aside class="col1q-r sidebar">
<% end %>
Expand All @@ -13,7 +13,7 @@
<% end %>
<% if Flipflop.enabled?(:gdt) && access_type(@record) && gis_access_link(@record) %>
<h2 class="title hd-4">Access links</h2>
<h2 class="hd-3">Access links</h2>
<%= render partial: 'access_buttons' %>
<% end %>
Expand Down

0 comments on commit dc54ccf

Please sign in to comment.