Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UX feedback on access link sidebar #190

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

jazairi
Copy link
Contributor

@jazairi jazairi commented May 14, 2024

Why these changes are being introduced:

UXWS has requested some changes to the access link sidebar (and the full record view more broadly).

Relevant ticket(s):

How this addresses that need:

  • Changes aria-label for the sidebar;
  • Updates heading typography to match the filter sidebar heading; and
  • Adds top margin to the full record.

Side effects of this change:

None.

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

UXWS will confirm that it looks the way they want it to, so this review is just to confirm the HTML/CSS changes are valid.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

Why these changes are being introduced:

UXWS has requested some changes to the access link sidebar (and
the full record view more broadly).

Relevant ticket(s):

* [GDT-319](https://mitlibraries.atlassian.net/browse/GDT-319)

How this addresses that need:

* Changes aria-label for the sidebar;
* Updates heading typography to match the filter sidebar heading; and
* Adds top margin to the full record.

Side effects of this change:

None.
@mitlib mitlib temporarily deployed to timdex-ui-pi-gdt-319-ux-vd2k4o May 14, 2024 16:43 Inactive
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9083065244

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.632%

Totals Coverage Status
Change from base Build 9037528205: 0.2%
Covered Lines: 577
Relevant Lines: 585

💛 - Coveralls

@jazairi jazairi temporarily deployed to timdex-ui-pi-gdt-319-ux-vd2k4o May 14, 2024 16:47 Inactive
@JPrevost JPrevost self-assigned this May 14, 2024
@jazairi jazairi merged commit e616f95 into main May 14, 2024
5 checks passed
@jazairi jazairi deleted the gdt-319-ux-feedback branch May 14, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants